Add initial testing support #44
Conversation
| public String getDisplayName() { | ||
| return displayName; | ||
| } | ||
| public String getDisplayName() { |
There was a problem hiding this comment.
All other files are indented with 4 spaces per tab, this brings this file into line with that.
There was a problem hiding this comment.
Ah, kk. Thought it was tab, plus space.
👍
| public String getUrlName() { | ||
| return urlName; | ||
| } | ||
| public String getUrlName() { |
| @@ -353,17 +339,14 @@ private boolean performForApplication(Run<?, ?> build, FilePath workspace, EnvVa | |||
| EnvAction envData = new EnvAction(); | |||
| build.addAction(envData); | |||
|
|
|||
| if (envData != null) { | |||
There was a problem hiding this comment.
No longer guarding against a null envData? Actually, will it ever not be null?
There was a problem hiding this comment.
It's safe because Java guarantees that the new operator will never return null.
|
These tests look awesome. |
|
Thanks :) The code style is the one I used on my last, and only, substantial java project, where it was heavily enforced - so now I'm completely institutionalised. It also happens to be the default code style used by the intelliJ IDE. If you disagree with it I can change it though, I have no strong feelings about the choice of code style. |
|
Don't disagree on the convention, just curious. I'm mostly concerned with consistency more than anything. Thx! |
|
Hi @SimonStJG thank you so much for these contributions. Sorry to be an arse, but can I get you to fix your PR as master has moved on a bit since you did this. I'd love to get this in for the next release if possible. |
|
Hi @mezpahlan I'd forgotten all about this :) Sure will find some time this weekend to fix it. |
* Remove pointless null checks * Use Jenkins.getInstance as Hudson.getIntance is deprecated * Use try-with-resources where possible
|
@mezpahlan All sorted now I hope. |
|
I've edited the title for the PR as this is clearly more than just retrofit tests! :) |
Tests which I wrote as part of PR 41.